app/components/VersionSelector.vue (2)

328-346: Make the first all-versions load single-flight.

Line 328 only blocks repeat clicks on the same row. If a second row is toggled before the first request resolves, loadAllVersions() will still start another fetch. Sharing one in-flight promise at component scope keeps the new “load once” behaviour true under parallel interaction.

Possible approach

+let allVersionsPromise: Promise<PackageVersionInfo[]> | null = null
+
 async function loadAllVersions(): Promise<PackageVersionInfo[]> {
   if (allVersionsCache.value) return allVersionsCache.value
+  if (allVersionsPromise) return allVersionsPromise
 
-  isLoadingAll.value = true
-  try {
-    const versions = await fetchAllPackageVersions(props.packageName)
-    allVersionsCache.value = versions
-    hasLoadedAll.value = true
-    return versions
-  } finally {
-    isLoadingAll.value = false
-  }
+  allVersionsPromise = (async () => {
+    isLoadingAll.value = true
+    try {
+      const versions = await fetchAllPackageVersions(props.packageName)
+      allVersionsCache.value = versions
+      hasLoadedAll.value = true
+      return versions
+    } finally {
+      isLoadingAll.value = false
+      allVersionsPromise = null
+    }
+  })()
+
+  return allVersionsPromise
 }

---

679-680: Please add a direct assertion for the new footer route.

This now switches the footer to the version-history page, but test/nuxt/components/VersionSelector.spec.ts:144-159 still only checks the label text. An href assertion here would keep the routing fix covered.

Small test addition

 it('shows "View all X versions" link', async () => {
   ...
   await button.trigger('click')
 
   expect(component.text()).toContain('View all 3 versions')
+  expect(
+    component.find('a[href="/package/test-package/versions"]').exists(),
+  ).toBe(true)
 })

As per coding guidelines, "Write unit tests for core functionality using `vitest`."

test/nuxt/components/VersionSelector.spec.ts (2)

429-469: Strengthen the hidden-before-expand precondition in this regression test.

This case can still pass if 0.9.x is visible too early, because it never asserts initial hidden state and starts with 0.9.0 already present in versions.

Proposed test hardening

     const component = await mountSuspended(VersionSelector, {
       props: {
         packageName: 'test-package',
         currentVersion: '1.0.0',
-        versions: { '1.0.0': {}, '0.9.0': {} },
+        versions: { '1.0.0': {} },
         distTags: { latest: '1.0.0' },
         urlPattern: '/package-docs/test-package/v/{version}',
       },
     })

     const button = component.find('button[aria-haspopup="listbox"]')
     await button.trigger('click')
+    expect(component.find('[role="listbox"]').text()).not.toContain('0.9')

     const expandButton = component.find('[role="listbox"] button[aria-expanded="false"]')
     await expandButton.trigger('click')

---

550-579: Prefer asserting reset on a semantic distTags change, not just object identity.

setProps({ distTags: { latest: '1.0.0' } }) reuses equivalent values, so the test can pass even if only reference changes are observed.

Proposed adjustment

-      await component.setProps({ distTags: { latest: '1.0.0' } })
+      await component.setProps({ distTags: { latest: '1.0.0', next: '0.9.0' } })